domain: avoid check schema changed when change is tiflash replica status #13034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13034 +/- ##
===========================================
Coverage 80.1514% 80.1514%
===========================================
Files 468 468
Lines 111177 111177
===========================================
Hits 89110 89110
Misses 15241 15241
Partials 6826 6826 |
bb7133
reviewed
Nov 1, 2019
domain/domain.go
Outdated
| @@ -254,6 +254,9 @@ func (do *Domain) tryLoadSchemaDiffs(m *meta.Meta, usedVersion, newVersion int64 | |||
| if err != nil { | |||
| return false, nil, err | |||
| } | |||
| if diff.Type == model.ActionUpdateTiFlashReplicaStatus || diff.Type == model.ActionSetTiFlashReplica { | |||
There was a problem hiding this comment.
Since we may add more skippable types, how about adding a function like skippableSchemaCheckTypes(diff.Type)?
zimulala
reviewed
Nov 1, 2019
|
/run-all-tests |
|
/run-mybatis-test |
|
/run-all-tests |
AilinKid
reviewed
Nov 5, 2019
| tblIDs = append(tblIDs, ids...) | ||
| } | ||
| builder.Build() | ||
| return true, tblIDs, nil | ||
| } | ||
|
|
||
| func canSkipSchemaCheckerDDL(tp model.ActionType) bool { | ||
| switch tp { | ||
| case model.ActionUpdateTiFlashReplicaStatus, model.ActionSetTiFlashReplica: |
There was a problem hiding this comment.
By now two options here, how about use if A||B? maybe fast.
There was a problem hiding this comment.
em... I prefer switch😂
|
/run-unit-test |
AilinKid
approved these changes
Nov 5, 2019
AilinKid
added
status/LGT3
|
/merge |
sre-bot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for 13130, 12895, 13108, 13107, 12628, 13089, 13090 |
|
/run-all-tests |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Feb 21, 2020
…tus (pingcap#13034) Signed-off-by: crazycs <crazycs520@gmail.com>
bb7133
pushed a commit
that referenced
this pull request
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Some DDL change no need to add to
schemaChecker.Such as:
Maybe below DDL type also no need to add to
schemaChecker:What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release note