Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinJSONTypeSig #12854

Merged
merged 2 commits into from
Oct 21, 2019
Merged

expression: implement vectorized evaluation for builtinJSONTypeSig #12854

merged 2 commits into from
Oct 21, 2019

Conversation

js00070
Copy link
Contributor

@js00070 js00070 commented Oct 21, 2019

What problem does this PR solve?

implement vectorized evaluation for builtinJSONTypeSig mentioned at #12104

What is changed and how it works?

about 100% faster

BenchmarkVectorizedBuiltinJSONFunc/builtinJSONTypeSig-VecBuiltinFunc-12                    76419             15707 ns/op               0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONTypeSig-NonVecBuiltinFunc-12                 39229             30186 ns/op               0 B/op          0 allocs/op

Check List

Tests

  • Unit test

@js00070 js00070 requested a review from a team as a code owner October 21, 2019 11:56
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Oct 21, 2019
@ghost ghost requested review from wshwsh12 and removed request for a team October 21, 2019 11:56
@wshwsh12 wshwsh12 requested review from qw4990 and SunRunAway October 21, 2019 11:57
wshwsh12
wshwsh12 reviewed Oct 21, 2019
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zz-jason
zz-jason approved these changes Oct 21, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Oct 21, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 21, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Oct 21, 2019

@js00070 merge failed.

@codecov
Copy link

codecov bot commented Oct 21, 2019 •
edited
Loading

Codecov Report

Merging #12854 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12854   +/-   ##
===========================================
  Coverage   80.1712%   80.1712%           
===========================================
  Files           465        465           
  Lines        107460     107460           
===========================================
  Hits          86152      86152           
  Misses        14879      14879           
  Partials       6429       6429

@ngaut ngaut merged commit 92c31cb into pingcap:master Oct 21, 2019
@js00070 js00070 deleted the vecJSONType branch November 7, 2019 11:08
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@js00070 @XiaTianliang
implement vectorized builtinJSONTypeSig (pingcap#12854)
6c04bb5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@js00070 @sre-bot @zz-jason @wshwsh12 @ngaut