expression: implement vectorized evaluation for builtinJSONQuoteSig
#12831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
qw4990
added
status/can-merge
|
Your auto merge job has been accepted, waiting for 12780, 12830 |
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #12831 +/- ##
===========================================
Coverage 80.0028% 80.0028%
===========================================
Files 465 465
Lines 106590 106590
===========================================
Hits 85275 85275
Misses 14940 14940
Partials 6375 6375 |
Deardrops
reviewed
Nov 22, 2019
| @@ -42,7 +42,9 @@ var vecBuiltinJSONCases = map[string][]vecExprBenchCase{ | |||
| ast.JSONRemove: {}, | |||
| ast.JSONMerge: {}, | |||
| ast.JSONInsert: {}, | |||
| ast.JSONQuote: {}, | |||
| ast.JSONQuote: { | |||
| {retEvalType: types.ETString, childrenTypes: []types.EvalType{types.ETJson}}, | |||
There was a problem hiding this comment.
There is a Bug, fixed in #13688
{retEvalType: types.ETString, childrenTypes: []types.EvalType{types.ETString}},
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
implement vectorized evaluation for
builtinJSONQuoteSigin #12104What is changed and how it works?
about 20% faster
Check List
Tests