Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for 'builtinCastTimeAsJSONSig' #12795

Merged
merged 4 commits into from
Oct 18, 2019
Merged

expression: implement vectorized evaluation for 'builtinCastTimeAsJSONSig' #12795

merged 4 commits into from
Oct 18, 2019

Conversation

tsthght
Copy link
Contributor

@tsthght tsthght commented Oct 17, 2019

What problem does this PR solve?

Implement vectorized evaluation for builtinCastTimeAsJSONSig, for #12104

What is changed and how it works?

BenchmarkVectorizedBuiltinCastFunc/builtinCastTimeAsJSONSig-VecBuiltinFunc-8         	    2000	    815621 ns/op	  227569 B/op	   13640 allocs/op
BenchmarkVectorizedBuiltinCastFunc/builtinCastTimeAsJSONSig-NonVecBuiltinFunc-8      	    2000	    839064 ns/op	  227564 B/op	   13640 allocs/op

Check List

Tests

  • Unit test

@tsthght tsthght requested a review from a team as a code owner October 17, 2019 11:36
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Oct 17, 2019
@ghost ghost requested review from wshwsh12 and removed request for a team October 17, 2019 11:36
@codecov
Copy link

codecov bot commented Oct 17, 2019 •
edited
Loading

Codecov Report

Merging #12795 into master will increase coverage by 0.0549%.
The diff coverage is 78.9473%.

@@               Coverage Diff                @@
##             master     #12795        +/-   ##
================================================
+ Coverage   79.9966%   80.0515%   +0.0549%     
================================================
  Files           465        462         -3     
  Lines        106427     105873       -554     
================================================
- Hits          85138      84753       -385     
+ Misses        14937      14794       -143     
+ Partials       6352       6326        -26

@wshwsh12 wshwsh12 requested a review from qw4990 October 17, 2019 13:09
qw4990
qw4990 reviewed Oct 18, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 18, 2019
wshwsh12
wshwsh12 approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 18, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 18, 2019

/run-all-tests

@sre-bot sre-bot merged commit 79e3e75 into pingcap:master Oct 18, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@tsthght @XiaTianliang
expression: implement vectorized evaluation for 'builtinCastTimeAsJSO…
4155b3b 
…NSig' (pingcap#12795)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@wshwsh12 wshwsh12 wshwsh12 approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tsthght @sre-bot @qw4990 @wshwsh12