expression: implement vectorized evaluation for builtinWeekDaySig
#12667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chacha923
requested review from
qw4990,
Reminiscent,
SunRunAway and
XuHuaiyu
as code owners
chacha923
changed the title
builtinWeekDaySig support vectorized evaluationbuiltinWeekDaySig support vectorized evaluation
Codecov Report
@@ Coverage Diff @@
## master #12667 +/- ##
===========================================
Coverage 80.0902% 80.0902%
===========================================
Files 465 465
Lines 107249 107249
===========================================
Hits 85896 85896
Misses 14944 14944
Partials 6409 6409 |
qw4990
changed the title
builtinWeekDaySig support vectorized evaluationbuiltinWeekDaySig
qw4990
reviewed
Oct 14, 2019
ghost
requested review from
chacha923
force-pushed
the
master
branch
2 times, most recently
from
bb50c1e to
12ae08e
Compare
qw4990
reviewed
Oct 16, 2019
expression/builtin_time_vec.go
Outdated
Comment on lines
209
to
213
| i64s[i] = 0 | ||
| continue |
There was a problem hiding this comment.
Should we set this row to null and use handleInvlaidTimeError to handle this error in this case?
There was a problem hiding this comment.
you right, i see old implement also drop handleInvalidTimeError if date is zero, it is right to refer the implement of builtinDateSig?
XuHuaiyu
reviewed
Oct 16, 2019
expression/builtin_time_vec.go
Outdated
| return err | ||
| } | ||
| defer b.bufAllocator.put(buf) | ||
| if err := b.args[0].VecEvalTime(b.ctx, input, buf); err != nil { |
XuHuaiyu
reviewed
Oct 18, 2019
SunRunAway
reviewed
Oct 18, 2019
qw4990
added
status/LGT2
|
/run-all-tests |
|
@chacha923 merge failed. |
|
/run-unit-test |
|
@chacha923 Please sign the CLA license. |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Implement vectorized evaluation for builtinWeekDaySig for #12103.
What is changed and how it works?
Check List
Tests
Unit test