store/tikv: make cache ttl configurable #12647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: disksing <i@disksing.com>
Codecov Report
@@ Coverage Diff @@
## master #12647 +/- ##
================================================
- Coverage 79.9038% 79.8601% -0.0437%
================================================
Files 462 461 -1
Lines 104393 103804 -589
================================================
- Hits 83414 82898 -516
+ Misses 14889 14814 -75
- Partials 6090 6092 +2 |
zimulala
reviewed
Oct 12, 2019
| @@ -70,6 +71,7 @@ txn-total-size-limit=2000 | |||
| [tikv-client] | |||
| commit-timeout="41s" | |||
| max-batch-size=128 | |||
| region-cache-ttl=6000 | |||
There was a problem hiding this comment.
It seems that we don't check it. region-cache-ttl is written to configure file, but we don't check it.
lonng
reviewed
Oct 12, 2019
config/config.toml.example
Outdated
| @@ -283,6 +283,10 @@ batch-wait-size = 8 | |||
| # Enable chunk encoded data. | |||
| enable-arrow = true | |||
|
|
|||
| # If a Region has not been accessed for more than the given duration, it | |||
There was a problem hiding this comment.
Do we need to add the unit of region-cache-ttl to the comment (second)?
Signed-off-by: disksing <i@disksing.com>
zimulala
added
status/LGT2
|
/run-all-tests |
|
cherry pick to release-3.0 failed |
|
cherry pick to release-3.1 failed |
|
It seems that, not for sure, we failed to cherry-pick this commit to release-3.0. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @disksing PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: disksing i@disksing.com
What problem does this PR solve?
Fix #12646
What is changed and how it works?
Add item in config file.
Check List
Tests
Related changes
Release note
RegionCacheTTL