Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinLpadSig #12635

Merged
merged 12 commits into from
Oct 15, 2019
Merged

expression: implement vectorized evaluation for builtinLpadSig #12635

merged 12 commits into from
Oct 15, 2019

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Oct 11, 2019

What problem does this PR solve?

Implement vectorized evaluation for builtinLpadSig.
12106

What is changed and how it works?

goos: darwin
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinStringFunc/builtinLpadSig-VecBuiltinFunc-4     4388  276216 ns/op   5808 B/op  448 allocs/op
BenchmarkVectorizedBuiltinStringFunc/builtinLpadSig-NonVecBuiltinFunc-4  3367  356918 ns/op  22832 B/op  1423 allocs/op

Check List

Tests

  • Unit test
  • Integration test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Oct 11, 2019
@codecov
Copy link

codecov bot commented Oct 12, 2019 •
edited
Loading

Codecov Report

Merging #12635 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12635   +/-   ##
===========================================
  Coverage   79.8918%   79.8918%           
===========================================
  Files           462        462           
  Lines        105072     105072           
===========================================
  Hits          83944      83944           
  Misses        14910      14910           
  Partials       6218       6218

qw4990
qw4990 reviewed Oct 14, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@b41sh Please solve the conflict.

@b41sh
Copy link
Member Author

b41sh commented Oct 14, 2019

@b41sh Please solve the conflict.

@qw4990 done

XuHuaiyu
XuHuaiyu reviewed Oct 14, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@b41sh b41sh requested a review from a team as a code owner October 14, 2019 10:42
@ghost ghost requested review from SunRunAway and XuHuaiyu and removed request for a team October 14, 2019 10:42
@Reminiscent Reminiscent removed their request for review October 14, 2019 11:41
@qw4990 qw4990 added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 15, 2019
@XuHuaiyu XuHuaiyu removed their request for review October 15, 2019 03:18
qw4990
qw4990 approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 removed the status/LGT1 Indicates that a PR has LGTM 1. label Oct 15, 2019
@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Oct 15, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 15, 2019

Your auto merge job has been accepted, waiting for 12696

@zz-jason zz-jason removed the request for review from SunRunAway October 15, 2019 03:28
@sre-bot
Copy link
Contributor

sre-bot commented Oct 15, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Oct 15, 2019

/run-all-tests

@sre-bot sre-bot merged commit ca1731a into pingcap:master Oct 15, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@b41sh @XiaTianliang
expression: implement vectorized evaluation for builtinLpadSig (pin…
2100311 
…gcap#12635)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@b41sh @sre-bot @SunRunAway @qw4990 @XuHuaiyu @zz-jason