Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinDecimalIsNullSig #12522

Merged
merged 5 commits into from
Oct 8, 2019
Merged

expression: implement vectorized evaluation for builtinDecimalIsNullSig #12522

merged 5 commits into from
Oct 8, 2019

Conversation

tangwz
Copy link
Contributor

@tangwz tangwz commented Oct 6, 2019

What problem does this PR solve?

Implement vectorized evaluation for builtinDecimalIsNullSig.
Issue: #12103

What is changed and how it works?

BenchmarkVectorizedBuiltinOpFunc/builtinDecimalIsNullSig-VecBuiltinFunc-4                 359746              2949 ns/op               0 B/op            0 allocs/op
BenchmarkVectorizedBuiltinOpFunc/builtinDecimalIsNullSig-NonVecBuiltinFunc-4               61214             19323 ns/op               0 B/op            0 allocs/op

Check List

Tests

  • Unit test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Oct 6, 2019
@tangwz tangwz changed the title expression: implement vectorized evaluation for builtinDecimalIsNullSig expression: implement vectorized evaluation for builtinDecimalIsNullSig Oct 6, 2019
@zz-jason zz-jason requested review from qw4990 and SunRunAway October 7, 2019 03:22
@qw4990 qw4990 requested a review from Reminiscent October 7, 2019 09:28
qw4990
qw4990 reviewed Oct 7, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 7, 2019
@qw4990
Copy link
Contributor

qw4990 commented Oct 8, 2019

/run-unit-test

@codecov
Copy link

codecov bot commented Oct 8, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@7aedd50). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12522   +/-   ##
===========================================
  Coverage          ?   79.9861%           
===========================================
  Files             ?        460           
  Lines             ?     102474           
  Branches          ?          0           
===========================================
  Hits              ?      81965           
  Misses            ?      14555           
  Partials          ?       5954

Reminiscent
Reminiscent previously approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent removed the request for review from SunRunAway October 8, 2019 03:01
@Reminiscent Reminiscent added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 8, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 8, 2019

Your auto merge job has been accepted, waiting for 12485, 12523

@sre-bot
Copy link
Contributor

sre-bot commented Oct 8, 2019

@tangwz merge failed.

@qw4990
Copy link
Contributor

qw4990 commented Oct 8, 2019

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Oct 8, 2019

/run-check-dev-2

@qw4990
Copy link
Contributor

qw4990 commented Oct 8, 2019

/run-check_dev_2

@qw4990
Copy link
Contributor

qw4990 commented Oct 8, 2019

/build

@SunRunAway SunRunAway removed their request for review October 8, 2019 06:22
@XuHuaiyu XuHuaiyu removed their request for review October 8, 2019 06:28
@qw4990 qw4990 merged commit 740b490 into pingcap:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@Reminiscent Reminiscent Reminiscent left review comments

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tangwz @qw4990 @sre-bot @Reminiscent @zz-jason