expression: implement vectorized evaluation for builtinLocate3ArgsSig
#12510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-unit-test |
Codecov Report
@@ Coverage Diff @@
## master #12510 +/- ##
===========================================
Coverage 80.1145% 80.1145%
===========================================
Files 464 464
Lines 106500 106500
===========================================
Hits 85322 85322
Misses 14992 14992
Partials 6186 6186 |
qw4990
reviewed
Oct 2, 2019
qw4990
reviewed
Oct 2, 2019
…-builtinLocate3ArgsSig
|
/run-unit-test |
qw4990
reviewed
Oct 8, 2019
…-builtinLocate3ArgsSig
fzhedu
reviewed
Oct 8, 2019
SunRunAway
reviewed
Oct 9, 2019
| result.MergeNulls(buf, buf1) | ||
| i64s := result.Int64s() | ||
| for i := 0; i < n; i++ { | ||
| if result.IsNull(i) { |
There was a problem hiding this comment.
Consider this case, b.args[2] is null but the result is not null.
mysql> SELECT LOCATE('bar', 'foobarbar', NULL);
+----------------------------------+
| LOCATE('bar', 'foobarbar', NULL) |
+----------------------------------+
| 0 |
+----------------------------------+
1 row in set (0.00 sec)There was a problem hiding this comment.
My test result is correct
mysql> SELECT LOCATE('bar', 'foobarbar', NULL);
+----------------------------------+
| LOCATE('bar', 'foobarbar', NULL) |
+----------------------------------+
| NULL |
+----------------------------------+
1 row in set (0.00 sec)
There was a problem hiding this comment.
can args[0] and args[1] be null?
There was a problem hiding this comment.
yes, any args is null will result in null
There was a problem hiding this comment.
Consider this case, b.args[2] is null but the result is not null.
mysql> SELECT LOCATE('bar', 'foobarbar', NULL); +----------------------------------+ | LOCATE('bar', 'foobarbar', NULL) | +----------------------------------+ | 0 | +----------------------------------+ 1 row in set (0.00 sec)
In MySQL 8.x, this SQL returns NULL.
…1sh/tidb into vecexpr-builtinLocate3ArgsSig
qw4990
added
status/can-merge
|
Your auto merge job has been accepted, waiting for 12662 |
|
/run-all-tests |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Implement vectorized evaluation for
builtinLocate3ArgsSig.12106
What is changed and how it works?
Check List
Tests