Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add a new way to calculate TPS (#12411) #12505

Merged
merged 3 commits into from
Oct 10, 2019
Merged

*: add a new way to calculate TPS (#12411) #12505

merged 3 commits into from
Oct 10, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Sep 30, 2019

cherry-pick #12411 to release-3.0

What problem does this PR solve?

Add a new way to calculate TPS.

What is changed and how it works?

Using TPS = (Com_commit + Com_rollback) / Seconds to calculate TPS.

Check List

Tests

  • No code

Screen Shot 2019-09-26 at 12 47 53

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Write release note for bug-fix or new feature.

@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 30, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Sep 30, 2019
Merged
jackysp
jackysp reviewed Oct 8, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Oct 8, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Oct 8, 2019

Your auto merge job has been accepted, waiting for 12500

@sre-bot
Copy link
Contributor Author

sre-bot commented Oct 8, 2019

/run-all-tests

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 9, 2019
@zimulala
Copy link
Contributor

zimulala commented Oct 9, 2019

PTAL @coocood

XuHuaiyu
XuHuaiyu approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 9, 2019
@zimulala zimulala merged commit 96dc595 into pingcap:release-3.0 Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
component/metrics status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sre-bot @zimulala @jackysp @XuHuaiyu