*: Refactoring reading logic of virtual generate column #12407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-unit-test |
Codecov Report
@@ Coverage Diff @@
## master #12407 +/- ##
================================================
+ Coverage 80.1577% 80.8396% +0.6818%
================================================
Files 471 471
Lines 113571 116699 +3128
================================================
+ Hits 91036 94339 +3303
+ Misses 15440 15292 -148
+ Partials 7095 7068 -27 |
wjhuang2016
added
sig/planner
|
This pr depends on other pr for mysql_test which still WIP |
|
/rebuild |
wjhuang2016
requested review from
qw4990,
Reminiscent,
SunRunAway and
XuHuaiyu
as code owners
wjhuang2016
added
status/LGT3
|
Wait for tidb_test PR 915 |
|
@winoros, @Deardrops, @lamxTyler, @eurekaka, @bb7133, PTAL. |
|
/run-all-tests tidb-test=pr/915 |
1 similar comment
|
/run-all-tests tidb-test=pr/915 |
|
@winoros, @Deardrops, @lamxTyler, @eurekaka, @bb7133, PTAL. |
2 similar comments
|
@winoros, @Deardrops, @lamxTyler, @eurekaka, @bb7133, PTAL. |
|
@winoros, @Deardrops, @lamxTyler, @eurekaka, @bb7133, PTAL. |
zz-jason
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for 13385 |
zz-jason
removed
the
status/can-merge
|
/run-all-tests |
|
/run-all-tests tidb-test=pr/915 |
wjhuang2016
force-pushed
the
virtual_column_dev
branch
from
0108289 to
54346df
Compare
|
/run-all-tests tidb-test=pr/915 |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Refactoring reading logic of virtual generate column, and Fix #5189.
After this pr, index on virtual column can be used.
What is changed and how it works?
Next()function, so that we can treat virtual column as ordinary column in planner. To do that, we need to expand virtual column with its dependent column so that TiKV will return sufficient data to compute virtual column.Check List
Tests
The new tests are added on tidb_test/mysql_test
Code changes
Side effects
Related changes
Release note