log: move autocommit varable value into connection info #12310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imtbkcat
added
type/enhancement
Codecov Report
@@ Coverage Diff @@
## master #12310 +/- ##
===========================================
Coverage 79.9653% 79.9653%
===========================================
Files 460 460
Lines 103221 103221
===========================================
Hits 82541 82541
Misses 14684 14684
Partials 5996 5996 |
jackysp
reviewed
Sep 23, 2019
server/conn.go
Outdated
| autoCommit = 1 | ||
| } | ||
| return fmt.Sprintf("id:%d, addr:%s status:%d, collation:%s, user:%s autocommit:%d", | ||
| cc.connectionID, cc.bufReadConn.RemoteAddr(), cc.ctx.Status(), collationStr, cc.user, autoCommit, |
There was a problem hiding this comment.
I think it is better to format the output of cc.ctx.Status(). Because it already contains the autocommit status.
jackysp
reviewed
Sep 23, 2019
| @@ -188,7 +188,9 @@ func (e *SetExecutor) setSysVariable(name string, v *expression.VarAssignment) e | |||
| valStr, err = value.ToString() | |||
| terror.Log(err) | |||
| } | |||
| logutil.BgLogger().Info("set session var", zap.Uint64("conn", sessionVars.ConnectionID), zap.String("name", name), zap.String("val", valStr)) | |||
| if name != variable.AutoCommit { | |||
| logutil.BgLogger().Info("set session var", zap.Uint64("conn", sessionVars.ConnectionID), zap.String("name", name), zap.String("val", valStr)) | |||
imtbkcat
force-pushed
the
var_log
branch
2 times, most recently
from
93bdb0b
to
f6f925c
Compare
|
LGTM |
|
/run-all-tests tidb-test=pr/875 |
|
/run-all-tests tidb-test=pr/875 |
|
/run-common-test tidb-test=pr/875 |
|
/run-all-tests tidb-test=pr/875 |
imtbkcat
added
status/can-merge
|
/run-all-tests |
|
@imtbkcat merge failed. |
|
/merge |
|
/run-all-tests |
|
@imtbkcat merge failed. |
|
/merge |
|
/run-all-tests |
|
@imtbkcat merge failed. |
imtbkcat
removed
the
status/can-merge
|
/run-check_dev |
|
cherry pick to release-3.0 failed |
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.1 failed |
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Oct 9, 2019
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Oct 9, 2019
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Oct 9, 2019
sre-bot
pushed a commit
that referenced
this pull request
Oct 13, 2019
sre-bot
pushed a commit
that referenced
this pull request
Oct 13, 2019
sre-bot
pushed a commit
that referenced
this pull request
Oct 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Some applications will set
autocommitvariable every time when they execute queries. This action will make tidb log full ofset session var.What is changed and how it works?
I remove this log info for
autocommitvariable and addautocommitvalue when print connection information into log.just like:
["command dispatched failed"] [conn=2] [connInfo="id:2, addr:127.0.0.1:52703 status:0, collation:utf8_general_ci, user:root autocommit:0"]Check List
Tests
Code changes
Side effects
Related changes
Release note