ddl: allow multiple unique attributes in a column
#12165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #12165 +/- ##
===========================================
Coverage 80.0927% 80.0927%
===========================================
Files 462 462
Lines 103726 103726
===========================================
Hits 83077 83077
Misses 14745 14745
Partials 5904 5904 |
|
/run-integration-common-test |
lonng
reviewed
Sep 17, 2019
tangenta
added
needs-cherry-pick-3.1
status/LGT1
lonng
approved these changes
Sep 28, 2019
|
/run-unit-test |
tangenta
added
the
status/can-merge
|
/run-all-tests |
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 in PR #12463 |
|
cherry pick to release-3.1 in PR #12464 |
tangenta
added a commit
to tangenta/tidb
that referenced
this pull request
Sep 29, 2019
sre-bot
pushed a commit
that referenced
this pull request
Oct 3, 2019
ngaut
pushed a commit
that referenced
this pull request
Oct 10, 2019
sre-bot
added a commit
that referenced
this pull request
Oct 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #12006.
What is changed and how it works?
Remove constraint name assignment when building
ast.ConstraintfromOptionofast.ColumnDef. LetcheckConstraintNamesdetermine the name later to avoid the name duplication.Check List
Tests
Code changes
Side effects
Related changes
Release note
uniqueattributes in a column