Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type: add db prefix to function name for not exist error messages (#11156) #12111

Merged
merged 4 commits into from
Sep 10, 2019

Conversation

zz-jason
Copy link
Member

cherry pick #11156 to release 3.0


What problem does this PR solve?

Close #11147

What is changed and how it works?

add db prefix to function name for not exist error messages

Check List

Tests

  • Unit test
  • Integration test

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mode of expression/scalar_function_test.go is changed. It seems unexcepted.

@zz-jason
Copy link
Member Author

The mode of expression/scalar_function_test.go is changed. It seems unexcepted.

@XuHuaiyu Changed back

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 7f1f66e into pingcap:release-3.0 Sep 10, 2019
@zz-jason zz-jason deleted the cherry-pick/3.0-11156 branch September 10, 2019 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants