*: refactoring the code of batchChecker

[tiancaiamao]

What problem does this PR solve?

The batchChecker is difficult to maintain, we should try to get rid of it.

CREATE TABLE `t` (
  `a` int(11) NOT NULL,
  `b` int(11) NOT NULL,
  `c` int(11) DEFAULT NULL,
  `d` int(11) DEFAULT NULL,
  `e` int(11) DEFAULT NULL,
  PRIMARY KEY (`a`,`b`),
  UNIQUE KEY `b` (`b`,`c`,`d`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin
PARTITION BY RANGE ( `b` ) (
  PARTITION p0 VALUES LESS THAN (4),
  PARTITION p1 VALUES LESS THAN (7),
  PARTITION p2 VALUES LESS THAN (11)
) ;

insert into t values (1,2,3,4,5);
insert into t values (1,2,3,4,5),(6,2,3,4,6) on duplicate key update e = e + values(e);

Expect:

mysql> select * from t;
+---+---+------+------+------+
| a | b | c    | d    | e    |
+---+---+------+------+------+
| 1 | 2 |    3 |    4 |   16 |
+---+---+------+------+------+
1 row in set (0.00 sec)

Get:

mysql> select * from t;
+---+---+------+------+------+
| a | b | c    | d    | e    |
+---+---+------+------+------+
| 1 | 2 |    3 |    4 |   11 |
+---+---+------+------+------+
1 row in set (0.00 sec)

What is changed and how it works?

The first step: do not use it.
The second step: clean up the code.

In this commit, I catch the BatchGet result into the snapshot, in this way we can achieve the same goal as the batchChecker
I re-implement the insert ... on duplicate key update ... without using the batchChecker.

Check List

Tests

• Unit test

Side effects

• Possible performance regression (unlikely)

Related changes

• Need to cherry-pick to the release branch

Release note

• Write release note for bug-fix or new feature.

Fix bugs of insert ... on duplicate update on the partitioned table

[tiancaiamao]

PTAL @jackysp @lysu @coocood

[codecov]

Codecov Report

Merging #12108 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12108   +/-   ##
===========================================
  Coverage   81.5473%   81.5473%           
===========================================
  Files           449        449           
  Lines         97124      97124           
===========================================
  Hits          79202      79202           
  Misses        12317      12317           
  Partials       5605       5605

[jackysp]

LGTM

[jackysp]

/run-all-tests

[tiancaiamao]

/run-all-tests

[tiancaiamao]

/rebuild

[lysu]

LGTM, so update, replace also need do same thing?

[tiancaiamao]

Yes, if we want to remove the batchChecker totally. @lysu

[tiancaiamao]

/run-all-tests

[imtbkcat]

LGTM

[sre-bot]

cherry pick to release-3.0 failed

[sre-bot]

It seems that, not for sure, we failed to cherry-pick this commit to release-3.0. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @tiancaiamao PTAL.