main : check --config-check should has --config flag specified first. #11855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AilinKid
changed the title
AilinKid
changed the title
Codecov Report
@@ Coverage Diff @@
## master #11855 +/- ##
=========================================
Coverage 81.562% 81.562%
=========================================
Files 435 435
Lines 94105 94105
=========================================
Hits 76754 76754
Misses 11863 11863
Partials 5488 5488 |
AilinKid
added
needs-cherry-pick-2.1
require-LGT3
zimulala
reviewed
Aug 24, 2019
| // configCheck should have the config file specified | ||
| if *configCheck { | ||
| fmt.Fprintln(os.Stderr, "config check failed", errors.New("no config file specified for config-check")) | ||
| os.Exit(1) |
There was a problem hiding this comment.
Em... it's not in test file .
This is same as previous config valid code when tidb start, Fprintln to Stderr with err.
Cause user specified no config file, we new an error here.
Refer to this:
the right case, the fail case is what I have added.
There was a problem hiding this comment.
I know it isn't the test file, you can see MustNil is called on line 347.
There was a problem hiding this comment.
Enen, got it. I've update my upper comment.
zimulala
reviewed
Aug 24, 2019
AilinKid
changed the title
zimulala
added
status/LGT2
|
LGTM |
|
cherry pick to release-3.0 failed |
|
cherry pick to release-2.1 failed |
AilinKid
added a commit
to AilinKid/tidb
that referenced
this pull request
Aug 26, 2019
…pingcap#11855) * check --config-check flag should has --config flag specified first.
AilinKid
added a commit
to AilinKid/tidb
that referenced
this pull request
Aug 26, 2019
…pingcap#11855) * check --config-check flag should has --config flag specified first.
sre-bot
pushed a commit
that referenced
this pull request
Aug 27, 2019
sre-bot
pushed a commit
that referenced
this pull request
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
Make sure --config is specified first when it has --config-check flag, then talk about file validation.
Otherwise, return config check failed cause no config file specified.
Check List
Tests
manual test
Code changes
modified in loadconfig.go
Side effects
no
Related changes
no
Release Note
check --config-check should have --config flag specified first.