planner: unfold the wildcard when creating view #11818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
AndrewDi
force-pushed
the
view/remove_wildcard
branch
2 times, most recently
from
b8143de to
413210a
Compare
Codecov Report
@@ Coverage Diff @@
## master #11818 +/- ##
===========================================
Coverage 80.5501% 80.5501%
===========================================
Files 465 465
Lines 109358 109358
===========================================
Hits 88088 88088
Misses 14850 14850
Partials 6420 6420 |
XuHuaiyu
reviewed
Aug 23, 2019
zz-jason
reviewed
Aug 24, 2019
XuHuaiyu
changed the title
XuHuaiyu
reviewed
Sep 2, 2019
zz-jason
reviewed
Sep 10, 2019
zz-jason
added
status/can-merge
|
/run-all-tests |
|
@AndrewDi merge failed. |
|
/run-all-tests |
|
/run-integration-common-test tidb-test=pr/890 |
|
@AndrewDi CREATE TABLE t1 (id INTEGER, sex CHAR(1));
CREATE VIEW v AS SELECT id, SUM(id) OVER w, sex FROM t1 WINDOW w AS (PARTITION BY sex ORDER BY id ROWS BETWEEN 2 PRECEDING AND 1 PRECEDING);
SELECT * FROM v; |
|
@AndrewDi any update? |
|
/run-all-tests |
AndrewDi
force-pushed
the
view/remove_wildcard
branch
from
4a0ee36 to
ffb2791
Compare
eurekaka
approved these changes
Oct 22, 2019
|
/run-all-tests tidb-test=pr/925 |
|
/rebuild |
1 similar comment
|
/rebuild |
|
/run-all-tests |
|
/run-all-tests tidb-test=pr/925 |
|
/run-all-tests tidb-test=pr/925 |
|
/run-integration-test |
|
/run-sqllogic-test |
|
/run-common-test |
|
/run-integration-common-test tidb-test=pr/925 |
|
/run-integration-common-test tidb-test=pr/925 |
XuHuaiyu
changed the title
XuHuaiyu
pushed a commit
to XuHuaiyu/tidb
that referenced
this pull request
Oct 24, 2019
lfkdsk
pushed a commit
to JustProject/tidb
that referenced
this pull request
Oct 24, 2019
XuHuaiyu
pushed a commit
to XuHuaiyu/tidb
that referenced
this pull request
Oct 25, 2019
sre-bot
pushed a commit
that referenced
this pull request
Oct 28, 2019
ngaut
pushed a commit
that referenced
this pull request
Oct 28, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
As part of View implement, remove view's wildcard and expand it.
What is changed and how it works?
ref proposal Proposal: Implement View
Check List
Tests
Description
Let's take a example with create view,
Before this PR，View will store select statement like
After this PR, View will store select statement like