-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sessionctx/binloginfo: fix uncomment pre_split_regions ddl-querys in binlog #11762
Merged
Merged
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1718d9b
sessionctx/binloginfo: fix uncomment pre_split_regions ddl querys in …
crazycs520 a0ca779
address comment
crazycs520 41da1a4
combine comment
crazycs520 eca81e5
use slice
crazycs520 bf7746a
remove redundant code
crazycs520 dcc7809
fix test
crazycs520 4548b56
address comment
crazycs520 a4edad8
Merge branch 'master' into fix-pre-split-bin-log
crazycs520 eecf981
address comment to remove redundant code
crazycs520 3493380
Merge branch 'master' into fix-pre-split-bin-log
bb7133 7fdee22
Merge branch 'master' into fix-pre-split-bin-log
crazycs520 dca1909
Merge branch 'master' into fix-pre-split-bin-log
crazycs520 54fabd1
Merge branch 'master' into fix-pre-split-bin-log
crazycs520 fbb4e64
add comment
crazycs520 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some comments for this function.