Skip to content

Conversation

foreyes
Copy link
Contributor

@foreyes foreyes commented Aug 14, 2019

What problem does this PR solve?

Revert hint scope change from #11364

What is changed and how it works?

Stop always push hint into hint stack when meet a new query block.

Check List

Tests

  • Unit test

Side effects

  • Change the scope of optimizer hint.

Related changes

  • Fix TPCC Performance regression

@foreyes foreyes changed the title revert hint scope & remove test planner: revert optimizer hint scope Aug 14, 2019
@foreyes
Copy link
Contributor Author

foreyes commented Aug 14, 2019

/run-all-tests

@foreyes foreyes requested review from zz-jason and XuHuaiyu August 14, 2019 06:47
@foreyes
Copy link
Contributor Author

foreyes commented Aug 14, 2019

PTAL. @zz-jason @XuHuaiyu

@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #11740 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11740   +/-   ##
===========================================
  Coverage   81.6782%   81.6782%           
===========================================
  Files           433        433           
  Lines         94134      94134           
===========================================
  Hits          76887      76887           
  Misses        11821      11821           
  Partials       5426       5426

@foreyes
Copy link
Contributor Author

foreyes commented Aug 14, 2019

/run-unit-test

1 similar comment
@foreyes
Copy link
Contributor Author

foreyes commented Aug 15, 2019

/run-unit-test

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. labels Aug 15, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 15, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Aug 15, 2019

@foreyes merge failed.

@foreyes
Copy link
Contributor Author

foreyes commented Aug 15, 2019

/run-unit-test

@foreyes foreyes merged commit f866bb4 into pingcap:master Aug 15, 2019
@foreyes foreyes deleted the dev/revert_hint_scope branch August 15, 2019 05:49
foreyes added a commit to foreyes/tidb that referenced this pull request Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants