Skip to content

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Aug 7, 2019

What problem does this PR solve?

Cherry-pick #11655 to release 3.0.

Code changes

  • Has exported variable/fields change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation
  • Need to be included in the release note

@jackysp jackysp added type/enhancement The issue or PR belongs to an enhancement. type/3.0 cherry-pick labels Aug 7, 2019
@coocood
Copy link
Member

coocood commented Aug 7, 2019

LGTM

Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Aug 8, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 8, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Aug 8, 2019

@jackysp merge failed.

@jackysp
Copy link
Member Author

jackysp commented Aug 8, 2019

/run-auto-merge

@sre-bot
Copy link
Contributor

sre-bot commented Aug 8, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Aug 8, 2019

@jackysp merge failed.

@jackysp
Copy link
Member Author

jackysp commented Aug 8, 2019

/run-auto-merge

@sre-bot
Copy link
Contributor

sre-bot commented Aug 8, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Aug 8, 2019

@jackysp merge failed.

@jackysp
Copy link
Member Author

jackysp commented Aug 8, 2019

/run-unit-test

@jackysp jackysp merged commit b066cba into pingcap:release-3.0 Aug 8, 2019
@jackysp jackysp deleted the rename_backoff_var_3.0 branch February 27, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants