store/tikv: refine streaming client re-create log and use a smarter backoff strategy #11307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiancaiamao
added
type/enhancement
Codecov Report
@@ Coverage Diff @@
## master #11307 +/- ##
==============================================
- Coverage 81.53% 81.2694% -0.2607%
==============================================
Files 424 423 -1
Lines 91408 90152 -1256
==============================================
- Hits 74525 73266 -1259
+ Misses 11594 11578 -16
- Partials 5289 5308 +19 |
|
PTAL @jackysp |
|
/run-all-tests |
SunRunAway
suggested changes
Jul 19, 2019
|
PTAL @lysu |
|
/run-all-tests |
SunRunAway
added
status/LGT2
|
cherry pick to release-3.0 failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When TiKV is down, or restart and bind to another port, the re-create streaming client loop can't perceive the changes.
Although we use the recycle idle connections mechanism to handle that, the error log is still boring and makes our users confusing.
What is changed and how it works?
Check List
Tests
Related changes