planner: unsigned pk cannot be pushed as index column #11094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winoros
added
type/bugfix
|
/run-all-tests |
zz-jason
reviewed
Jul 8, 2019
…/winoros/tidb into disable-push-unsignedpk-to-index
Codecov Report
@@ Coverage Diff @@
## master #11094 +/- ##
===========================================
Coverage 81.3411% 81.3411%
===========================================
Files 423 423
Lines 90102 90102
===========================================
Hits 73290 73290
Misses 11524 11524
Partials 5288 5288 |
zz-jason
added
status/LGT2
…/winoros/tidb into disable-push-unsignedpk-to-index
zz-jason
approved these changes
Jul 12, 2019
|
/rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
It's a hard work to keep data in order if the index range contains unsigned pk since the pk is the last column not the first column.
What is changed and how it works?
Disabled it when the pk is unsigned.
Check List
Tests
Related changes