Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Fix issue#1089 #1106

Merged
merged 1 commit into from
Apr 18, 2016
Merged

*: Fix issue#1089 #1106

merged 1 commit into from
Apr 18, 2016

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Apr 18, 2016 •
edited by shenli
Loading

fix issue #1089

@coocood
Copy link
Member

coocood commented Apr 18, 2016

LGTM

@shenli
Copy link
Member

shenli commented Apr 18, 2016

LGTM
But please raise an issue to fix "For approximate-value numbers, the result depends on the C library. On many systems, this means that ROUND() uses the “round to nearest even” rule: A value with any fractional part is rounded to the nearest even integer."

@zimulala zimulala merged commit 895e9a0 into master Apr 18, 2016
@zimulala zimulala deleted the zimuxia/issue-1089 branch April 18, 2016 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zimulala @coocood @shenli