executor: tiny refactor the runtimeStats collection code
#10917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove redundant code and do it in one place
tiancaiamao
added
type/enhancement
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #10917 +/- ##
================================================
+ Coverage 81.0421% 81.0853% +0.0431%
================================================
Files 419 419
Lines 88934 88878 -56
================================================
- Hits 72074 72067 -7
+ Misses 11621 11588 -33
+ Partials 5239 5223 -16 |
Codecov Report
@@ Coverage Diff @@
## master #10917 +/- ##
===========================================
Coverage 81.3542% 81.3542%
===========================================
Files 419 419
Lines 90192 90192
===========================================
Hits 73375 73375
Misses 11571 11571
Partials 5246 5246 |
ngaut
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Better code
What is changed and how it works?
Instead of calling
if runtimeStats != nil ...check in every executor function,we can just do it in the
executor.Nextfunction.Remove redundant code and put the check in one place.
Check List
Tests