Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema/slow_query: add host column in slow_query table. #10693

Merged
merged 9 commits into from
Jun 4, 2019

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Jun 4, 2019

What problem does this PR solve?

Add host field to classification by host.

What is changed and how it works?

Add host field column to slow_query table. This is split value of "user".

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

@crazycs520
Copy link
Contributor Author

@winkyao @zz-jason PTAL

infoschema/slow_log.go Outdated Show resolved Hide resolved
infoschema/slow_log.go Outdated Show resolved Hide resolved
@@ -162,6 +163,7 @@ type slowQueryTuple struct {
time time.Time
txnStartTs uint64
user string
ip string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think host is better

@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #10693 into master will increase coverage by 0.0318%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10693        +/-   ##
================================================
+ Coverage   78.3279%   78.3598%   +0.0318%     
================================================
  Files           414        414                
  Lines         87666      87721        +55     
================================================
+ Hits          68667      68738        +71     
+ Misses        13854      13841        -13     
+ Partials       5145       5142         -3

@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #10693 into master will decrease coverage by 0.0011%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10693        +/-   ##
================================================
- Coverage   79.6423%   79.6412%   -0.0012%     
================================================
  Files           414        414                
  Lines         87731      87736         +5     
================================================
+ Hits          69871      69874         +3     
- Misses        12688      12689         +1     
- Partials       5172       5173         +1

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 4, 2019
@crazycs520
Copy link
Contributor Author

/run-all-tests

@bb7133 bb7133 changed the title infoschema/slow_query: add ip column in slow_query table. infoschema/slow_query: add host column in slow_query table. Jun 4, 2019
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1. type/usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants