CONTRIBUTING.md: Add usability team in PR guidelines #10601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10601 +/- ##
================================================
+ Coverage 77.3812% 77.4141% +0.0328%
================================================
Files 413 413
Lines 87463 87422 -41
================================================
- Hits 67680 67677 -3
+ Misses 14577 14546 -31
+ Partials 5206 5199 -7 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #10601 +/- ##
================================================
+ Coverage 77.3812% 77.4141% +0.0328%
================================================
Files 413 413
Lines 87463 87422 -41
================================================
- Hits 67680 67677 -3
+ Misses 14577 14546 -31
+ Partials 5206 5199 -7 |
|
/run-all-tests tidb-test=pr/824 |
jackysp
added
status/all tests passed
status/LGT2
db-storage
pushed a commit
to db-storage/tidb
that referenced
this pull request
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Adding a configuration option or a new error message are important to get right. Once added, they are difficult to change since they imply a contract with users. Error messages are also hard to fix later since context is harder to determine. We should try and review up front where we can.
What is changed and how it works?
This updates the contributing guide to ask for @pingcap/usability-team to be pinged if there is a configuration option added, or an error message.
The initial group consists of @morgo @kolbe @scsldb @shenli .
Check List
Tests
Side effects
Related changes