planner, executor: fix show view privileges for explain #10585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10585 +/- ##
================================================
+ Coverage 77.2406% 77.3825% +0.1419%
================================================
Files 413 413
Lines 87476 87468 -8
================================================
+ Hits 67567 67685 +118
+ Misses 14717 14575 -142
- Partials 5192 5208 +16 |
|
PTAL @erjiaqing |
crazycs520
added
status/LGT2
|
/run-all-tests |
crazycs520
approved these changes
May 27, 2019
db-storage
pushed a commit
to db-storage/tidb
that referenced
this pull request
May 29, 2019
bb7133
added a commit
to bb7133/tidb
that referenced
this pull request
May 29, 2019
winkyao
pushed a commit
that referenced
this pull request
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR try to close #9875
What is changed and how it works?
An
IsExplainStmtis added to StatementContext, and it helps to checkSHOW VIEWprivilege inEXPLAIN SELECT ...a view.Check List
Tests
Code changes