Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: update pessimistic lock ttl. #10578

Merged
merged 2 commits into from
May 24, 2019
Merged

config: update pessimistic lock ttl. #10578

merged 2 commits into from
May 24, 2019

Conversation

coocood
Copy link
Member

@coocood coocood commented May 23, 2019

What problem does this PR solve?

Make the config easier to set and validate the value.

What is changed and how it works?

  • change the type of PessimisticTTL to string.
  • parse and validate the value is between 15s and 60s.

Check List

Tests

  • Unit test

@coocood
Copy link
Member Author

coocood commented May 23, 2019

@tiancaiamao @jackysp PTAL

@codecov
Copy link

codecov bot commented May 23, 2019 •
edited
Loading

Codecov Report

Merging #10578 into master will decrease coverage by 0.0013%.
The diff coverage is 77.7777%.

@@               Coverage Diff                @@
##             master     #10578        +/-   ##
================================================
- Coverage   77.3778%   77.3765%   -0.0014%     
================================================
  Files           413        413                
  Lines         87410      87418         +8     
================================================
+ Hits          67636      67641         +5     
+ Misses        14582      14574         -8     
- Partials       5192       5203        +11

jackysp
jackysp reviewed May 23, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood
Copy link
Member Author

coocood commented May 24, 2019

/run-all-tests

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT2 Indicates that a PR has LGTM 2. label May 24, 2019
@coocood coocood merged commit 412f6ef into pingcap:master May 24, 2019
@coocood coocood deleted the pessimistic-ttl branch May 24, 2019 03:41
db-storage pushed a commit to db-storage/tidb that referenced this pull request May 29, 2019
@coocood @db-storage
config: update pessimistic lock ttl. (pingcap#10578)
6a1c74b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coocood @tiancaiamao @jackysp