-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: fix wrong result of Not
/IsTrue
/IsFalse
functions
#10498
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10498 +/- ##
===========================================
Coverage 81.5496% 81.5496%
===========================================
Files 435 435
Lines 94058 94058
===========================================
Hits 76704 76704
Misses 11883 11883
Partials 5471 5471 |
/run-all-tests |
/run-unit-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
should we cherry pick this pr to release 3.0 and 2.1? |
@eurekaka merge failed. |
/run-integration-common-test |
@zz-jason if we cherry-pick this PR, we need to cherry-pick commits in tipb (which has no release branch at all?) and tikv as well... |
Yeah, that's a huge work. |
What problem does this PR solve?
Fix #10443
Besides from the case mentioned in the above issue, another wrong result case is:
What is changed and how it works?
IsTrue
/IsFalse
, if the argument type is string or json, do not convert it to int, add new builtin function signature for string types;Not
, convert its evaluation to useIsFalse
andIsNull
;Check List
Tests
Code changes
Side effects
Related changes