stats: merge non-overlapped feedback when update bucket count #10476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alivxxx
added
type/enhancement
Codecov Report
@@ Coverage Diff @@
## master #10476 +/- ##
==============================================
- Coverage 77.3311% 77.32% -0.0112%
==============================================
Files 413 413
Lines 87274 87262 -12
==============================================
- Hits 67490 67471 -19
+ Misses 14602 14601 -1
- Partials 5182 5190 +8 |
XuHuaiyu
reviewed
May 20, 2019
winoros
reviewed
May 20, 2019
alivxxx
requested review from
XuHuaiyu and
winoros
and removed request for
XuHuaiyu
winoros
reviewed
May 21, 2019
XuHuaiyu
reviewed
May 22, 2019
|
@winoros Added. |
|
/rebuild |
zz-jason
reviewed
May 22, 2019
|
/run-all-tests |
alivxxx
added
status/LGT2
alivxxx
added a commit
to alivxxx/tidb
that referenced
this pull request
May 22, 2019
zz-jason
pushed a commit
that referenced
this pull request
May 22, 2019
db-storage
pushed a commit
to db-storage/tidb
that referenced
this pull request
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #10365
What is changed and how it works?
When updating the bucket count, we first try to merge the max fraction of non-overlapped feedback that is contained in the bucket, the result bucket count will be more accurate than only use one feedback.
Check List
Tests
Code changes
Side effects
Related changes