planner: fix update privilege error #10085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiekeyi98
reviewed
Apr 9, 2019
planner/core/logical_plan_builder.go
Outdated
| @@ -2611,6 +2614,13 @@ func (b *PlanBuilder) buildUpdateLists(tableList []*ast.TableName, list []*ast.A | |||
| col := assign.Col | |||
|
|
|||
| dbName := col.DBName.L | |||
| // With sql below we need to get database by table alia name | |||
There was a problem hiding this comment.
What the alia stand for?
Suggested change
| // With sql below we need to get database by table alia name | |
| // With sql below, we need to get database by the table alias name. |
planner/core/logical_plan_builder.go
Outdated
| @@ -2611,6 +2614,13 @@ func (b *PlanBuilder) buildUpdateLists(tableList []*ast.TableName, list []*ast.A | |||
| col := assign.Col | |||
|
|
|||
| dbName := col.DBName.L | |||
| // With sql below we need to get database by table alia name | |||
| // update ap.record t inner join tp.record tt on t.id=tt.id set t.name=tt.name | |||
There was a problem hiding this comment.
Suggested change
| // update ap.record t inner join tp.record tt on t.id=tt.id set t.name=tt.name | |
| // issue#10028 |
xiekeyi98
changed the title
xiekeyi98
added
sig/planner
Codecov Report
@@ Coverage Diff @@
## master #10085 +/- ##
================================================
- Coverage 77.3341% 77.3312% -0.0029%
================================================
Files 412 412
Lines 85622 85629 +7
================================================
+ Hits 66215 66218 +3
- Misses 14389 14390 +1
- Partials 5018 5021 +3 |
|
/run-all-tests |
zz-jason
reviewed
May 5, 2019
planner/core/logical_plan_builder.go
Outdated
| @@ -2611,6 +2614,12 @@ func (b *PlanBuilder) buildUpdateLists(tableList []*ast.TableName, list []*ast.A | |||
| col := assign.Col | |||
|
|
|||
| dbName := col.DBName.L | |||
| // To solve issue#10028, we need to get database name by the table alias name. | |||
| for _, tbl := range tableList { | |||
There was a problem hiding this comment.
will it be faster if we pre-build a map[tblName]DBName and save this for loop?
zz-jason
reviewed
May 5, 2019
planner/core/logical_plan_builder.go
Outdated
| // To solve issue#10028, we need to get database name by the table alias name. | ||
| for _, tbl := range tableList { | ||
| if strings.EqualFold(tbl.Name.L, col.TblName.L) { | ||
| dbName = tbl.DBInfo.Name.L |
There was a problem hiding this comment.
BTW, after finding a dbName, we should break.
|
@zz-jason |
zz-jason
added
status/LGT2
|
/run-all-tests |
|
/run-mybatis-test |
|
@haplone Please cherry pick this commit to the release-2.1 branch |
|
@zz-jason func (b *planBuilder) buildUpdate(update *ast.UpdateStmt) (Plan, error) {
// ...
for _, t := range tableList {
dbName := t.Schema.L
if dbName == "" {
dbName = b.ctx.GetSessionVars().CurrentDB
}
// the mysql.UpdatePriv should be mysql.SelectPriv
b.visitInfo = appendVisitInfo(b.visitInfo, mysql.UpdatePriv, dbName, t.Name.L, "")
} |
|
seems we need to cherry pick #8376 to release 2.1 first @tiancaiamao |
winoros
pushed a commit
to winoros/tidb
that referenced
this pull request
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
issue10028
What is changed and how it works?
get the right database name for update privilege check in planner/core/logical_plan_builder.go#buildUpdate
Check List
Tests
Code changes
Side effects
Related changes
we need to fix in release-2.0 release-2.1 by another pr(buildUpdate logic has changed)