Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: add UT in show_test #10083

Merged
merged 4 commits into from
Apr 11, 2019
Merged

executor: add UT in show_test #10083

merged 4 commits into from
Apr 11, 2019

Conversation

xiekeyi98
Copy link
Contributor

@xiekeyi98 xiekeyi98 commented Apr 9, 2019 •
edited
Loading

What problem does this PR solve?

This case cannot run in MySQL-test regularly.
Move it to UT.

What is changed and how it works?

Add the case in show_test.go

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • None

Side effects

  • None

Related changes

  • None

This change is Reviewable

@xiekeyi98 xiekeyi98 added type/enhancement The issue or PR belongs to an enhancement. component/test sig/execution SIG execution labels Apr 9, 2019
@codecov
Copy link

codecov bot commented Apr 10, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@e90f3b9). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #10083   +/-   ##
===========================================
  Coverage          ?   78.1089%           
===========================================
  Files             ?        405           
  Lines             ?      82006           
  Branches          ?          0           
===========================================
  Hits              ?      64054           
  Misses            ?      13248           
  Partials          ?       4704

@xiekeyi98
Copy link
Contributor Author

@crazycs520 @zimulala PTAL.

winkyao
winkyao reviewed Apr 10, 2019
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crazycs520
crazycs520 reviewed Apr 10, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 10, 2019
@xiekeyi98
Copy link
Contributor Author

/run-all-tests

@xiekeyi98
Copy link
Contributor Author

/run-common-test

@crazycs520
Copy link
Contributor

/run-all-tests

@xiekeyi98
Copy link
Contributor Author

/run-unit-test

@xiekeyi98 xiekeyi98 merged commit 6958760 into pingcap:master Apr 11, 2019
@xiekeyi98 xiekeyi98 deleted the addUtInShowCreateView branch April 11, 2019 06:43
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@winkyao winkyao winkyao approved these changes

Assignees
No one assigned
Labels
component/test contribution This PR is from a community contributor. sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiekeyi98 @crazycs520 @winkyao @sre-bot