evaluator: change the remaining string functions. #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the remaining string functions.
| func builtinStrcmp(args []interface{}, _ context.Context) (interface{}, error) { | ||
| if args[0] == nil || args[1] == nil { | ||
| return nil, nil | ||
| func builtinStrcmp(args []types.Datum, _ context.Context) (d types.Datum, err error) { |
There was a problem hiding this comment.
Put d.SetNull() here, then if err != nil is true , we don't need to set it again?
|
LGTM |
| return nil, nil | ||
| func builtinStrcmp(args []types.Datum, _ context.Context) (d types.Datum, err error) { | ||
| if args[0].Kind() == types.KindNull || args[1].Kind() == types.KindNull { | ||
| return d, nil |
There was a problem hiding this comment.
Default kind for datum is KindNull?
|
LGTM |
zxylvlp
added a commit
that referenced
this pull request
Mar 22, 2016
evaluator: change the remaining string functions.
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Sep 28, 2021
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Oct 8, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the remaining string functions.