Upgrade of Individual component using Tiup is doing a full reload again

[kabileshKabi]

Enhancement

This is enhancement for Tiup to check , if the version is matching for the component skip the upgrade and proceed.

Let me explain i have my cluster running with version 8.5.3 ie., the latest as of now. But My tiproxy is running with version 1.3.0

Cluster version and status:

Cluster type: tidb
Cluster name: Inctest
Cluster version: v8.5.3
Deploy user: tidb
SSH type: builtin

But now when i run the below command just to upgrade the tiproxy to 1.3.2

tiup cluster upgrade inctest v8.5.3 --tiproxy-version v1.3.2

will upgrade and restart component "            tiflash" to "v8.5.3",
will upgrade and restart component "                 pd" to "v8.5.3",
will upgrade and restart component "            tiproxy" to "v1.3.2",
will upgrade and restart component "               tikv" to "v8.5.3",
will upgrade and restart component "               tidb" to "v8.5.3",
will upgrade and restart component "         prometheus" to "v8.5.3",
will upgrade and restart component "            grafana" to "v8.5.3",
will upgrade and restart component "       alertmanager" to "",
will upgrade component     "node-exporter" to "",
will upgrade component "blackbox-exporter" to "".

The tiup proceed to run the upgrade for all the component without even making a check of the component
 version

Am not pretty sure its a bug or its enhancement requirement or am doing something wrong.

Enhancement:
------------
Tiup to make version check of the current components and proceed with the upgrade for needed components

This can reduced the reload time time of the cluster

[rpaik]

@bb7133 could you help assign this to the right person?

[xhebox]

This should be created in https://github.com/pingcap/tiup. It is expected, and can workaround by -R or other flags that limited the upgrade component. I think it makes sense, but it is not that easy to implement.

[kabileshKabi]

it would be solve by a version check between the cluster component and version mentioned in the command and skip the upgrade process if the version is matching

[xhebox]

it would be solve by a version check between the cluster component and version mentioned in the command and skip the upgrade process if the version is matching

Yeah, I know, I mean the internal implementation. May you move the issue to tiup repo? I'll take it when I am free, will be solved in the next release.

[kabileshKabi]

@xhebox i tried, it seems i couldnt change the project to tiup

[rpaik]

@kabileshKabi maybe it's easier to just open a new issue in TiUP and add a link to this issue as a reference?

You can then close the issue here in TiDB.....

[kabileshKabi]

create this request in Tiup: pingcap/tiup#2633