Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't return types.NameSlice for BuildLogicalPlanForTest function #47974

Closed
Defined2014 opened this issue Oct 25, 2023 · 2 comments · Fixed by #47988
Closed

Don't return types.NameSlice for BuildLogicalPlanForTest function #47974

Defined2014 opened this issue Oct 25, 2023 · 2 comments · Fixed by #47988
Assignees
@bagechengzi
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@Defined2014
Copy link
Contributor

Defined2014 commented Oct 25, 2023 •
edited
Loading

Enhancement

The BuildLogicalPlanForTest function returns p.OutputNames() which is never used. So we can delete it.
@Defined2014 Defined2014 added the type/enhancement The issue or PR belongs to an enhancement. label Oct 25, 2023
@Defined2014 Defined2014 changed the title Don't return Don't return types.NameSlice for BuildLogicalPlanForTest function Oct 25, 2023
@Defined2014 Defined2014 added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Oct 25, 2023
@bagechengzi
Copy link
Contributor

Hi, I would like to work on this issue, would you mind assign it to me

@Defined2014
Copy link
Contributor Author

Hi, I would like to work on this issue, would you mind assign it to me

Done

@bagechengzi bagechengzi mentioned this issue Oct 25, 2023
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Oct 26, 2023
@bagechengzi
enhancement: Modify the BuildLogicalPlanForTest function (#47988)
3a3a7d1 
close #47974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bagechengzi bagechengzi

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enhancement: Modify the BuildLogicalPlanForTest function bagechengzi/tidb
2 participants
@Defined2014 @bagechengzi