We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please answer these questions before submitting your issue. Thanks!
go test -tags intest github.com/pingcap/tidb/pkg/tablecodec -run TestBenchDaily -bench Ignore --outfile bench_daily.json
No error
panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1021b4d] goroutine 72 [running]: github.com/pingcap/tidb/pkg/tablecodec.flatten(0x442669?, {0x7, 0x0, 0x0, 0x0, {0x12d638c, 0x6}, {0xc00036e013, 0x1, 0x1}, ...}, ...) /home/genius/project/src/github.com/pingcap/tidb/pkg/tablecodec/tablecodec.go:401 +0x8d github.com/pingcap/tidb/pkg/tablecodec.EncodeValue(0x11a6c20?, {0xc000098b78, 0x0, 0x10}, {0x7, 0x0, 0x0, 0x0, {0x12d638c, 0x6}, ...}) /home/genius/project/src/github.com/pingcap/tidb/pkg/tablecodec/tablecodec.go:328 +0xa5 github.com/pingcap/tidb/pkg/tablecodec.BenchmarkEncodeValue(0xc00034c000) /home/genius/project/src/github.com/pingcap/tidb/pkg/tablecodec/tablecodec_test.go:568 +0x5c5 testing.(*B).runN(0xc00034c000, 0x1) /home/genius/project/go/src/testing/benchmark.go:193 +0x102 testing.(*B).run1.func1() /home/genius/project/go/src/testing/benchmark.go:233 +0x4e created by testing.(*B).run1 in goroutine 50 /home/genius/project/go/src/testing/benchmark.go:226 +0x90 exit status 2 FAIL github.com/pingcap/tidb/pkg/tablecodec 7.580s
I need to check is there anything wrong, or break by that commit
master
The text was updated successfully, but these errors were encountered:
Ref #25754
Sorry, something went wrong.
This seems to be because PR modified https://github.com/pingcap/tidb/blob/master/pkg/tablecodec/tablecodec.go#L401 and changed the parameter from sc to sc.TypeCtx, but in the benchmark test sc is nil
sc
sc.TypeCtx
TypeCtx
stmtctx, *: change TypeCtx field to a private field (#47742)
90bd2dd
close #47698, close #47752
stmtctx, *: change TypeCtx field to a private field (pingcap#47742)
b0f97bd
close pingcap#47698, close pingcap#47752
Successfully merging a pull request may close this issue.
Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)
2. What did you expect to see? (Required)
No error
3. What did you see instead (Required)
I need to check is there anything wrong, or break by that commit
4. What is your TiDB version? (Required)
master
The text was updated successfully, but these errors were encountered: