Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified the cancal/kill logic in tidb. #47075

Closed
wshwsh12 opened this issue Sep 19, 2023 · 0 comments · Fixed by #47063
Closed

Unified the cancal/kill logic in tidb. #47075

wshwsh12 opened this issue Sep 19, 2023 · 0 comments · Fixed by #47063
Assignees
@wshwsh12
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@wshwsh12
Copy link
Contributor

Enhancement

Currently there are many kinds of cancel/kill query logic in tidb, kill signal, max_excution_time, query_quota, global memory control..
They use different atomic variables, different checkpoints in the code, different exit methods (return err or panic).
They should be unified and we can exit the query as soon as possible.
@wshwsh12 wshwsh12 added the type/enhancement The issue or PR belongs to an enhancement. label Sep 19, 2023
@wshwsh12 wshwsh12 self-assigned this Sep 19, 2023
@wshwsh12 wshwsh12 mentioned this issue Sep 19, 2023
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Oct 23, 2023
@wshwsh12
*: unified the cancel/kill logic in tidb (#47063)
2a628c4 
close #47075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wshwsh12 wshwsh12

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: unified the cancel/kill logic in tidb wshwsh12/tidb
1 participant
@wshwsh12