Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema cache should try to correct previous wrong timestamp #46325

Closed
hihihuhu opened this issue Aug 22, 2023 · 0 comments · Fixed by #46326
Closed

schema cache should try to correct previous wrong timestamp #46325

hihihuhu opened this issue Aug 22, 2023 · 0 comments · Fixed by #46326
Assignees
Labels
severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@hihihuhu
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

when get schema encounters transient error when gets its timestamp, the timestamp of the schema is zero
https://github.com/pingcap/tidb/blob/v7.3.0/domain/domain.go#L223
it makes the cache useless because the timestamp is zero and it won't recover because the next success reload won't correct the timestamp until another ddl happens, the reload will exit at without correct the timestamp
https://github.com/pingcap/tidb/blob/v7.3.0/domain/domain.go#L227

2. What did you expect to see? (Required)

transient error should not prevent schema cache being useful forever

3. What did you see instead (Required)

schema cache is not useable

4. What is your TiDB version? (Required)

master

@hihihuhu hihihuhu added the type/bug The issue is confirmed as a bug. label Aug 22, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Aug 23, 2023
@xhebox xhebox removed may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Aug 25, 2023
crazycs520 pushed a commit to crazycs520/tidb that referenced this issue Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants