Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lightning: change the severity of pre-check items clusterResourceCheckItem and emptyRegionCheckItem #37654

Closed
niubell opened this issue Sep 7, 2022 · 0 comments · Fixed by #37657
Closed

Lightning: change the severity of pre-check items clusterResourceCheckItem and emptyRegionCheckItem #37654

niubell opened this issue Sep 7, 2022 · 0 comments · Fixed by #37657
Labels
affects-6.1 component/lightning This issue is related to Lightning of TiDB. type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@niubell
Copy link
Contributor

niubell commented Sep 7, 2022

Feature Request

Is your feature request related to a problem? Please describe:

Cluster-Capacity and Empty-Regions are two pre-check items in the Lightning pre-check phase and the severity is Critical.In Fact, the estimation of source data size by sampling is not very accurate, and too many empty(bigger than 1000) regions should not forbid Lightning running.

Describe the feature you'd like:

  • Change severity of clusterResourceCheckItem from Critical to Warning
  • Change severity of emptyRegionCheckItem from Critical to Warning

Describe alternatives you've considered:

None.

Teachability, Documentation, Adoption, Migration Strategy:

None.
@niubell niubell added the type/feature-request Categorizes issue or PR as related to a new feature. label Sep 7, 2022
@niubell niubell mentioned this issue Sep 7, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Sep 21, 2022
@niubell
Lightning: change severity of clusterResourceCheckItem,emptyRegionChe…
7cbbaac 
…ckItem from Critical to Warn (#37657)

close #37654
@ti-chi-bot ti-chi-bot mentioned this issue Dec 5, 2022
Merged
12 tasks
@Ivy-YinSu Ivy-YinSu added the component/lightning This issue is related to Lightning of TiDB. label Jan 18, 2023
ti-chi-bot added a commit that referenced this issue Jan 18, 2023
@ti-chi-bot
Lightning: change severity of clusterResourceCheckItem,emptyRegionChe…
e412d96 
…ckItem from Critical to Warn (#37657) (#39638)

close #37654
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.1 component/lightning This issue is related to Lightning of TiDB. type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
3 participants
@niubell @VelocityLight @Ivy-YinSu