Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb-lightning need to support fields starting with _ when the import file type is parquet #36980

Closed
glkappe opened this issue Aug 9, 2022 · 4 comments · Fixed by #36985
Closed

tidb-lightning need to support fields starting with _ when the import file type is parquet #36980

glkappe opened this issue Aug 9, 2022 · 4 comments · Fixed by #36985
Labels
affects-5.4 This bug affects 5.4.x versions. affects-6.1 affects-6.2 component/lightning This issue is related to Lightning of TiDB. severity/minor type/bug The issue is confirmed as a bug.

Comments

@glkappe
Copy link

glkappe commented Aug 9, 2022

Bug Report

Please answer these questions before submitting your issue. Thanks!

tidb-lightning need to support fields starting with _ when the import file type is parquet

1. Minimal reproduce step (Required)

  1. fields starting with _ of parquet
  2. use tidb-lightning import

2. What did you expect to see? (Required)

import success

3. What did you see instead (Required)

Root cause: PreCheckFailed: TiDB schema `test`.`tbl` doesn't have column pargo_prefix__abc, please check table schema

4. What is your TiDB version? (Required)

tidb、tidb-lightning ：v6.1.0
@glkappe glkappe added the type/bug The issue is confirmed as a bug. label Aug 9, 2022
@D3Hunter
Copy link
Contributor

D3Hunter commented Aug 9, 2022

duplicate with #36981

@D3Hunter D3Hunter mentioned this issue Aug 9, 2022
Merged
12 tasks
@glkappe
Copy link
Author

glkappe commented Aug 9, 2022

ok i wiil close this issue

@glkappe glkappe closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2022
@D3Hunter D3Hunter reopened this Aug 9, 2022
@D3Hunter
Copy link
Contributor

D3Hunter commented Aug 9, 2022

ok i wiil close this issue

will close automatically after pr merged

@jebter jebter added the component/lightning This issue is related to Lightning of TiDB. label Aug 10, 2022
@D3Hunter
Copy link
Contributor

https://github.com/xitongsys/parquet-go/blob/7a9be66324ca29f6ce14c66b239ba79c4896bf25/common/common.go#L603

ti-chi-bot pushed a commit that referenced this issue Aug 15, 2022
@D3Hunter
lightning: support column starts with slash/number/non-ascii for parq…
e4338c1 
…uet (#36985)

close #36980, close #36981
This was referenced Aug 15, 2022
Merged
Merged
Closed
ti-chi-bot pushed a commit that referenced this issue Aug 17, 2022
@ti-srebot
lightning: support column starts with slash/number/non-ascii for parq…
46ebd96 
…uet (#36985) (#37093)

close #36980, close #36981
ti-chi-bot pushed a commit that referenced this issue Aug 17, 2022
@ti-srebot
lightning: support column starts with slash/number/non-ascii for parq…
ed5dd79 
…uet (#36985) (#37092)

close #36980, close #36981
This was referenced Aug 29, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.4 This bug affects 5.4.x versions. affects-6.1 affects-6.2 component/lightning This issue is related to Lightning of TiDB. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lightning: support column starts with slash/number/non-ascii for parquet D3Hunter/tidb
3 participants
@D3Hunter @jebter @glkappe