Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression introduced by pr/31547 #32604

Closed
tiancaiamao opened this issue Feb 24, 2022 · 3 comments · Fixed by #32605
Closed

Performance regression introduced by pr/31547 #32604

tiancaiamao opened this issue Feb 24, 2022 · 3 comments · Fixed by #32605
Assignees
Labels
type/bug The issue is confirmed as a bug. type/performance type/regression

Comments

@tiancaiamao
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

See http://www.zenlife.tk:18081/
image

Verify it:

git checkout 9c64224c4951fdffb05f284b011c48c50c188a04
cd session;
go test -run XXX -bench BenchmarkInsertIntoSelect -benchmem -cpuprofile cpu2.out -memprofile mem2.out -benchtime 30s

Before this commit:

BenchmarkInsertIntoSelect-16    	     418	  85843376 ns/op	104122866 B/op	  405474 allocs/op

After this commit

BenchmarkInsertIntoSelect-16    	     264	 135987408 ns/op	151347408 B/op	  785351 allocs/op

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

@tiancaiamao
Copy link
Contributor Author

Ref #25754

@tiancaiamao
Copy link
Contributor Author

Profile before

image

vs After

image

@ekexium

@ekexium ekexium added type/regression and removed type/bug The issue is confirmed as a bug. labels Feb 24, 2022
@tiancaiamao
Copy link
Contributor Author

The other regression BenchmarkInsertWithIndex is also by this change.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug The issue is confirmed as a bug. type/performance type/regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants