Skip to content

buildValuesListOfInsert is slow when many ‘?’ in values #25992

@lysu

Description

@lysu

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

use prepare to execute

insert into t values(?, ?, ?), (?, ?, ?), (?, ?, ?), (?, ?, ?), (?, ?, ?), (?, ?, ?), (?, ?, ?), (?, ?, ?), (?, ?, ?), (?, ?, ?), (?, ?, ?), (?, ?, ?).....

2. What did you expect to see? (Required)

fast and low cpu usage in tidb

3. What did you see instead (Required)

hig cpu usage

image

it seems rewrite for each "?" is unessary

4. What is your TiDB version? (Required)

v5.0.0 (previous flamegraph's code line number is also v5.0.0.)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions