Skip to content

Metric batch_executor_token_wait_duration is incorrectly recorded #22516

Closed
@zyguan

Description

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

The buckets declared at metrics/tikvclient.go has a unit of nano second, however, it observed in the seconds at 2pc.go.

2. What did you expect to see? (Required)

metrics.TiKVTokenWaitDuration.Observe(batchExe.tokenWaitDuration)

3. What did you see instead (Required)

metrics.TiKVTokenWaitDuration.Observe(batchExe.tokenWaitDuration.Seconds())

4. What is your TiDB version? (Required)

master

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions