address comment

pingcap · Nov 27, 2023 · a49dc23 · a49dc23
1 parent fa2644f
commit a49dc23
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/br/pkg/lightning/backend/kv/sql2kv.go b/br/pkg/lightning/backend/kv/sql2kv.go
@@ -115,7 +115,7 @@ func CollectGeneratedColumns(se *Session, meta *model.TableInfo, cols []*table.C
 	var genCols []GeneratedCol
 	for i, col := range cols {
 		if col.GeneratedExpr != nil {
-			expr, err := expression.RewriteAstExpr(se, col.GeneratedExpr.Clone(), schema, names, true)
+			expr, err := expression.RewriteAstExpr(se, col.GeneratedExpr.Internal(), schema, names, true)
 			if err != nil {
 				return nil, err
 			}

diff --git a/pkg/table/column.go b/pkg/table/column.go
@@ -66,7 +66,7 @@ func NewClonableExprNode(ctor func() ast.ExprNode, internal ast.ExprNode) *Clona
 	}
 }
 
-// Clone mades a "copy" of the internal ast.ExprNode by reconstructing it.
+// Clone makes a "copy" of the internal ast.ExprNode by reconstructing it.
 func (n *ClonableExprNode) Clone() ast.ExprNode {
 	intest.AssertNotNil(n.ctor)
 	if n.ctor == nil {
@@ -76,7 +76,7 @@ func (n *ClonableExprNode) Clone() ast.ExprNode {
 }
 
 // Internal returns the reference of the internal ast.ExprNode.
-// Note: only use this method when you are sure that the internal ast.ExprNode is not modified.
+// Note: only use this method when you are sure that the internal ast.ExprNode is not modified concurrently.
 func (n *ClonableExprNode) Internal() ast.ExprNode {
 	return n.internal
 }