expression: implement vectorized evaluation for builtinLogicXorSig (#…

…12430)
pingcap · Sep 27, 2019 · 8379a1c · 8379a1c
1 parent 095bee9
commit 8379a1c
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 9 deletions.
diff --git a/expression/builtin_op_vec.go b/expression/builtin_op_vec.go
@@ -199,11 +199,42 @@ func (b *builtinBitXorSig) vecEvalInt(input *chunk.Chunk, result *chunk.Column)
 }
 
 func (b *builtinLogicXorSig) vectorized() bool {
-	return false
+	return true
 }
 
 func (b *builtinLogicXorSig) vecEvalInt(input *chunk.Chunk, result *chunk.Column) error {
-	return errors.Errorf("not implemented")
+	if err := b.args[0].VecEvalInt(b.ctx, input, result); err != nil {
+		return err
+	}
+
+	n := input.NumRows()
+	buf, err := b.bufAllocator.get(types.ETInt, n)
+	if err != nil {
+		return err
+	}
+	defer b.bufAllocator.put(buf)
+	if err := b.args[1].VecEvalInt(b.ctx, input, buf); err != nil {
+		return err
+	}
+
+	i64s := result.Int64s()
+	arg1s := buf.Int64s()
+	// Returns NULL if either operand is NULL.
+	// See https://dev.mysql.com/doc/refman/5.7/en/logical-operators.html#operator_xor
+	result.MergeNulls(buf)
+	for i := 0; i < n; i++ {
+		if result.IsNull(i) {
+			continue
+		}
+		arg0 := i64s[i]
+		arg1 := arg1s[i]
+		if (arg0 != 0 && arg1 != 0) || (arg0 == 0 && arg1 == 0) {
+			i64s[i] = 0
+		} else {
+			i64s[i] = 1
+		}
+	}
+	return nil
 }
 
 func (b *builtinBitAndSig) vectorized() bool {

diff --git a/expression/builtin_op_vec_test.go b/expression/builtin_op_vec_test.go
@@ -25,12 +25,14 @@ var vecBuiltinOpCases = map[string][]vecExprBenchCase{
 	ast.IsTruth:   {},
 	ast.IsFalsity: {},
 	ast.LogicOr: {
-		{retEvalType: types.ETInt, childrenTypes: []types.EvalType{types.ETInt, types.ETInt}, geners: makeBinaryLogicOpDataGens()},
+		{retEvalType: types.ETInt, childrenTypes: []types.EvalType{types.ETInt, types.ETInt}, geners: makeBinaryLogicOpDataGeners()},
 	},
-	ast.LogicXor: {},
-	ast.Xor:      {},
+	ast.LogicXor: {
+		{retEvalType: types.ETInt, childrenTypes: []types.EvalType{types.ETInt, types.ETInt}, geners: makeBinaryLogicOpDataGeners()},
+	},
+	ast.Xor: {},
 	ast.LogicAnd: {
-		{retEvalType: types.ETInt, childrenTypes: []types.EvalType{types.ETInt, types.ETInt}, geners: makeBinaryLogicOpDataGens()},
+		{retEvalType: types.ETInt, childrenTypes: []types.EvalType{types.ETInt, types.ETInt}, geners: makeBinaryLogicOpDataGeners()},
 	},
 	ast.UnaryNot:   {},
 	ast.UnaryMinus: {},
@@ -62,9 +64,7 @@ func makeGivenValsOrDefaultGener(vals []interface{}, eType types.EvalType) *give
 	return g
 }
 
-func makeBinaryLogicOpDataGens() []dataGenerator {
-	// TODO: This data generator currently only applies to AND and OR operators,
-	// so its name may be too generic.
+func makeBinaryLogicOpDataGeners() []dataGenerator {
 	pairs := [][]interface{}{
 		{nil, nil},
 		{0, nil},