*: Address comment

pingcap · Oct 14, 2015 · 641aeab · 641aeab · qiuyesuifeng · Oct 14, 2015
1 parent 25b571b
commit 641aeab
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/tidb-server/server/driver_tidb.go b/tidb-server/server/driver_tidb.go
@@ -21,6 +21,7 @@ import (
 	mysql "github.com/pingcap/tidb/mysqldef"
 	"github.com/pingcap/tidb/rset"
 	"github.com/pingcap/tidb/util/errors2"
+	"github.com/pingcap/tidb/util/types"
 )
 
 // TiDBDriver implements IDriver.
@@ -272,12 +273,12 @@ func convertColumnInfo(fld *field.ResultField) (ci *ColumnInfo) {
 	ci.Schema = fld.DBName
 	ci.Flag = uint16(fld.Flag)
 	ci.Charset = uint16(mysql.CharsetIDs[fld.Charset])
-	if fld.Flen == -1 {
+	if fld.Flen == types.UnspecifiedLength {
 		ci.ColumnLength = 0
 	} else {
 		ci.ColumnLength = uint32(fld.Flen)
 	}
-	if fld.Decimal == -1 {
+	if fld.Decimal == types.UnspecifiedLength {
 		ci.Decimal = 0
 	} else {
 		ci.Decimal = uint8(fld.Decimal)

diff --git a/util/types/field_type.go b/util/types/field_type.go
@@ -52,7 +52,7 @@ func NewFieldType(tp byte) *FieldType {
 	}
 }
 
-// CompactStr only consider Tp/CharsetBin/Flen/Deimal.
+// CompactStr only considers Tp/CharsetBin/Flen/Deimal.
 // This is used for showing column type in infoschema.
 func (ft *FieldType) CompactStr() string {
 	ts := TypeToStr(ft.Tp, ft.Charset)