follow comments

pingcap · Feb 8, 2023 · 511cc5a · 511cc5a
1 parent 40328b2
commit 511cc5a
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/domain/domain.go b/domain/domain.go
@@ -510,13 +510,12 @@ func (do *Domain) Reload() error {
 			version -= 1
 			is, hitCache, oldSchemaVersion, changes, err = do.loadInfoSchema(version)
 		}
-		if err != nil {
-			metrics.LoadSchemaDuration.Observe(time.Since(startTime).Seconds())
-			metrics.LoadSchemaCounter.WithLabelValues("failed").Inc()
-			return err
-		}
 	}
 	metrics.LoadSchemaDuration.Observe(time.Since(startTime).Seconds())
+	if err != nil {
+		metrics.LoadSchemaCounter.WithLabelValues("failed").Inc()
+		return err
+	}
 	metrics.LoadSchemaCounter.WithLabelValues("succ").Inc()
 
 	// only update if it is not from cache