util: fix data race in the cpu test (#40154)

close #40125
pingcap · Dec 27, 2022 · 3c8f11d · 3c8f11d
1 parent ab01065
commit 3c8f11d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/util/cpu/BUILD.bazel b/util/cpu/BUILD.bazel
@@ -21,5 +21,6 @@ go_test(
     srcs = ["cpu_test.go"],
     embed = [":cpu"],
     flaky = True,
+    race = "on",
     deps = ["@com_github_stretchr_testify//require"],
 )
diff --git a/util/cpu/cpu_test.go b/util/cpu/cpu_test.go
@@ -24,8 +24,7 @@ import (
 )
 
 func TestCPUValue(t *testing.T) {
-	Observer := NewCPUObserver()
-	Observer.Start()
+	observer := NewCPUObserver()
 	exit := make(chan struct{})
 	var wg sync.WaitGroup
 	for i := 0; i < 10; i++ {
@@ -42,11 +41,11 @@ func TestCPUValue(t *testing.T) {
 			}
 		}()
 	}
-	Observer.Start()
+	observer.Start()
 	time.Sleep(5 * time.Second)
 	require.GreaterOrEqual(t, GetCPUUsage(), 0.0)
 	require.Less(t, GetCPUUsage(), 1.0)
-	Observer.Stop()
+	observer.Stop()
 	close(exit)
 	wg.Wait()
 }