address the comment

pingcap · Dec 13, 2022 · 1769e8f · 1769e8f
1 parent 9f01939
commit 1769e8f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/sessionctx/variable/tidb_vars.go b/sessionctx/variable/tidb_vars.go
@@ -1141,7 +1141,7 @@ const (
 	DefPasswordReuseHistory                          = 0
 	DefPasswordReuseTime                             = 0
 	DefTiDBStoreBatchSize                            = 0
-	DefTiDBHistoricalStatsDuration                   = time.Hour * 24 * 7
+	DefTiDBHistoricalStatsDuration                   = 7 * 24 * time.Hour
 )
 
 // Process global variables.

diff --git a/statistics/handle/gc.go b/statistics/handle/gc.go
@@ -56,7 +56,9 @@ func (h *Handle) GCStats(is infoschema.InfoSchema, ddlLease time.Duration) error
 		}
 	}
 	if err := h.ClearOutdatedHistoryStats(); err != nil {
-		logutil.BgLogger().Warn("failed to gc outdated historical stats", zap.Duration("duration", variable.HistoricalStatsDuration.Load()))
+		logutil.BgLogger().Warn("failed to gc outdated historical stats",
+			zap.Duration("duration", variable.HistoricalStatsDuration.Load()),
+			zap.Error(err))
 	}
 	return h.removeDeletedExtendedStats(gcVer)
 }