Skip to content

Commit

Permalink
annotate TODO
Browse files Browse the repository at this point in the history
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
  • Loading branch information
Tristan1900 committed Jul 17, 2024
1 parent 0548118 commit 0387ae6
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions br/pkg/utils/error_handling.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
"sync"
)

// TODO: remove and mapped all to an error type
// UNSAFE! TODO: remove and map them to error types
var retryableErrorMsg = []string{
"server closed",
"connection refused",
Expand All @@ -29,7 +29,7 @@ var retryableErrorMsg = []string{
}

// non-retryable error messages
// TODO: remove and mapped all to an error type
// UNSAFE! TODO: remove and map them to error types
const (
ioMsg = "io"
notFoundMsg = "notfound"
Expand Down Expand Up @@ -120,7 +120,7 @@ func handleBackupProtoError(e *backuppb.Error) ErrorHandlingResult {
return ErrorHandlingResult{Unknown, unknownErrorMsg}
}

// HandleUnknownBackupError TODO: remove this method and map all the current unknown errors to an error type
// HandleUnknownBackupError UNSAFE! TODO: remove this method and map all the current unknown errors to error types
func HandleUnknownBackupError(msg string, uuid uint64, ec *ErrorContext) ErrorHandlingResult {
// UNSAFE! TODO: use meaningful error code instead of unstructured message to find failed to write error.
logger := log.L().With(zap.String("description", ec.description))
Expand Down

0 comments on commit 0387ae6

Please sign in to comment.